Refactor FullMeshLinked and ConnectAll() #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -273,10 +273,12 @@ func TestNetworkSetup(t *testing.T) { | |||
|
|
|||
| func TestStreams(t *testing.T) { | |||
|
|
|||
| mn, err := FullMeshConnected(context.Background(), 3) | |||
| mn, err := WithNPeers(context.Background(), 3) | |||
There was a problem hiding this comment.
I dont see what we lose by continuing to use FullMeshConnected in cases like these. Maybe just make FullMeshConnected be:
func FullMeshConnected(...) {
mn, err := WithNPeers(context.Background(), 3)
if err != nil {
nil, err
}
mn.LinkAll()
mn.ConnectAll()
return mn, nil
}i think this is different from @whyrusleeping's case.
There was a problem hiding this comment.
Was thinking of doing this one instead.
rht
force-pushed
the
rm-full-mesh-linked
branch
3 times, most recently
from
2af62d2
to
ef0bf10
Compare
rht
changed the title
rht
force-pushed
the
rm-full-mesh-linked
branch
from
ef0bf10
to
34110fc
Compare
|
Looks like there are 2 different |
|
@rht i think some tests are counting on avoiding duplicates. maybe pass in a bool? or just have two functions? |
|
|
License: MIT Signed-off-by: rht <[email protected]>
rht
force-pushed
the
rm-full-mesh-linked
branch
from
34110fc
to
63c7741
Compare
|
Since |
|
@rht LGTM |
rht
changed the title
jbenet
added a commit
that referenced
this pull request
Aug 28, 2015
Refactor FullMeshLinked and ConnectAll()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.