Remove hardcoded "/" #1984
Merged
Remove hardcoded "/" #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also strings.Split -> path.Segments. |
|
(in #1984, stating '/' directly is a crime) |
rht
changed the title
License: MIT Signed-off-by: rht <[email protected]>
rht
changed the title
License: MIT Signed-off-by: rht <[email protected]>
|
Somehow the tests passed. |
| cmd = cmd.Subcommand(name) | ||
|
|
||
| if cmd == nil { | ||
| pathS := strings.Join(path[0:i], "/") | ||
| pathS := path.Join(pth[0:i]) |
There was a problem hiding this comment.
I know you didnt add it, but that [0:i] not being just [:i] is bothering me
There was a problem hiding this comment.
There are 6 occurences of '[0:'. Purging them once for all.
|
LGTM |
License: MIT Signed-off-by: rht <[email protected]>
|
this LGTM. thanks @rht |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small fixes.
Another option, it would be faster to just use strings.Join(elms, "/") and put it in path/path.go, since golang's path does path.Clean of every elements.