bitswap: redo: don't re-provide blocks we've provided very recently #3253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #3105 (bitswap: don't re-provide blocks we've provided very recently) broke adding files via the filestore (i.e., --no-copy, #2634). The filestore code requires that all writes go through to the blockstore. In addition the blockstore already checks if a block already exists. This change avoids calling
Has()
is the blockservice and instead modifies the blockstore interface to return the blocks actually added.#3105 also changed AddBlocks (now AddObjects) to just return the blocks added. This pull request restores the original behavior. At this point I am not even sure if this return value is used anywhere.