Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap: increase wantlist resend delay to one minute #3448

Merged
merged 1 commit into from
Nov 30, 2016

Conversation

whyrusleeping
Copy link
Member

I honestly thought this was removed a while ago, but here it is (see line 299). I'm going to bump this up to once per minute to make sure nothing weird starts happening. Then later we can completely remove it.

License: MIT
Signed-off-by: Jeromy [email protected]

@whyrusleeping whyrusleeping added status/in-progress In progress need/review Needs a review labels Nov 30, 2016
@whyrusleeping whyrusleeping assigned ghost and Kubuxu Nov 30, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Nov 30, 2016

If it was in all the time, and every 10s, why we are having problems with wantlist consistency?

@whyrusleeping
Copy link
Member Author

yamux

@whyrusleeping
Copy link
Member Author

For example, check out goroutine 14008165 here: https://ipfs.io/ipfs/QmQn8YDTHWJzF7GVKUKanBzoxbzd5jQpwsgM2PfFVTKuGR

@Kubuxu
Copy link
Member

Kubuxu commented Nov 30, 2016

😢

LGTM

@whyrusleeping whyrusleeping merged commit 5e4ca03 into master Nov 30, 2016
@whyrusleeping whyrusleeping deleted the feat/wlist-resend-delay branch November 30, 2016 22:03
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Nov 30, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants