Announce relay addresses by default #4830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
ghost
assigned 
|
i think long term we want to figure out a way to bind to relays and announce specific addresses. |
|
Note that this would also close #4992 |
|
Can we reopen this? |
|
Should this be closed now in favour of AutoRelay? |
|
Yeah, we probably want to close this. |
Stebalien
removed
the
status/blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/go-libp2p-swarm#57
With this change we will announce the non-specific relay addresses. From my testing non-specific addresses work well-enough, at least with the current network structure.
There are also a couple of points in #4213 which may need to be addressed first for this to work well.