Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peering: add logs before many-second waits #7904

Merged
merged 1 commit into from
Feb 16, 2021
Merged

peering: add logs before many-second waits #7904

merged 1 commit into from
Feb 16, 2021

Conversation

mvdan
Copy link
Contributor

@mvdan mvdan commented Feb 6, 2021

This test takes a full minute to run, and I was honestly thinking my run
of "go test -v" had simply hung, as I saw no output and no apparent
resource usage.

The least we can do is print a few log messages before the potentially
long waits, to hint that we're still making progress. Each of these
"Eventually" and "Never" calls ends up blocking the test for a few
seconds at a time.

This test takes a full minute to run, and I was honestly thinking my run
of "go test -v" had simply hung, as I saw no output and no apparent
resource usage.

The least we can do is print a few log messages before the potentially
long waits, to hint that we're still making progress. Each of these
"Eventually" and "Never" calls ends up blocking the test for a few
seconds at a time.
@mvdan
Copy link
Contributor Author

mvdan commented Feb 7, 2021

The CI failure looks like some sort of unrelated timeout flake.

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this faster, but this is a good stop-gap.

@Stebalien
Copy link
Member

Hm... we may need to increase timeouts for the linter again...

@Stebalien Stebalien merged commit 33c93e2 into ipfs:master Feb 16, 2021
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
@mvdan mvdan deleted the peering-test-logs branch July 16, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants