feat: Delegated routing with custom configuration. #9274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
commented
Sep 13, 2022
This was referenced Sep 13, 2022
ajnavarro
force-pushed
the
feature/delegated-routing-v2
branch
from
e408da1
to
c0d9101
Compare
ajnavarro
force-pushed
the
feature/delegated-routing-v2
branch
from
a1ea310
to
7573b72
Compare
ajnavarro
force-pushed
the
feature/delegated-routing-v2
branch
3 times, most recently
from
5113650
to
0c32e28
Compare
Closed
ajnavarro
force-pushed
the
feature/delegated-routing-v2
branch
2 times, most recently
from
6491bc5
to
d59a23c
Compare
ajnavarro
commented
Sep 21, 2022
guseggert
requested changes
Sep 21, 2022
ajnavarro
force-pushed
the
feature/delegated-routing-v2
branch
2 times, most recently
from
79961eb
to
98a7acf
Compare
|
@ajnavarro : I don't think we should say "closes #9150" since that issue is done when reframe is used in Kubo in production. This PR is an important step but not the end. |
|
@BigLep removed that issue from the list. |
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Co-authored-by: Ivan Schasny <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
ajnavarro
force-pushed
the
feature/delegated-routing-v2
branch
from
36a8454
to
6fbe75d
Compare
ajnavarro
force-pushed
the
feature/delegated-routing-v2
branch
2 times, most recently
from
1f890c9
to
5307ed1
Compare
ajnavarro
force-pushed
the
feature/delegated-routing-v2
branch
from
5307ed1
to
a067db5
Compare
guseggert
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New multi-router configuration system based on https://hackmd.io/G1KRDEX5T3qyfoBMkIrBew#Methods
Durationconfig type, to make easier time string parsingIt: