Skip to content

Commit

Permalink
Removed unused and possibly ambiguous log levels
Browse files Browse the repository at this point in the history
DEBUG is defined in certain Windows libraries and often in various build systems.

The upper case log levels aren't used in the code base anymore either.
  • Loading branch information
netromdk committed Feb 14, 2018
1 parent 49edf89 commit c751011
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion examples/example.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ int main()
});

// enables all log
app.loglevel(crow::LogLevel::DEBUG);
app.loglevel(crow::LogLevel::Debug);
//crow::logger::setHandler(std::make_shared<ExampleLogHandler>());

app.port(18080)
Expand Down
2 changes: 1 addition & 1 deletion examples/example_vs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ int main()
});

// ignore all log
crow::logger::setLogLevel(crow::LogLevel::DEBUG);
crow::logger::setLogLevel(crow::LogLevel::Debug);
//crow::logger::setHandler(std::make_shared<ExampleLogHandler>());

app.port(18080)
Expand Down
8 changes: 0 additions & 8 deletions include/crow/logging.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@ namespace crow
{
enum class LogLevel
{
#ifndef ERROR
DEBUG = 0,
INFO,
WARNING,
ERROR,
CRITICAL,
#endif

Debug = 0,
Info,
Warning,
Expand Down

0 comments on commit c751011

Please sign in to comment.