Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

fix: replace node buffers with uint8arrays #49

Merged
merged 2 commits into from
Aug 4, 2020
Merged

fix: replace node buffers with uint8arrays #49

merged 2 commits into from
Aug 4, 2020

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Aug 3, 2020 •
edited
Loading

Depends on:

BREAKING CHANGE:

  • util.serialize now returns a Uint8Array
  • util.cid returns v1 CIDs

@achingbrain
fix: replace node buffers with uint8arrays
aba179c 
Depends on:

- [ ] multiformats/js-cid#117

BREAKING CHANGE:

- `util.serialize` now returns a Uint8Array
@achingbrain achingbrain requested a review from vmx August 3, 2020 17:10
@codecov
Copy link

codecov bot commented Aug 3, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3b4b7e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master       #49   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         1           
  Lines             ?        16           
  Branches          ?         0           
==========================================
  Hits              ?        16           
  Misses            ?         0           
  Partials          ?         0
Impacted Files Coverage Δ
src/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4b7e8...b54ca28. Read the comment docs.

rvagg
rvagg approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine, when the cids dep is resolved (which isn't strictly necessary here but would be logical to include!)

@achingbrain achingbrain mentioned this pull request Aug 4, 2020
Merged
7 tasks
@vmx vmx merged commit 0bb211a into master Aug 4, 2020
@vmx vmx deleted the fix/replace-node-buffers-with-uint8arrays branch August 4, 2020 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vmx vmx vmx approved these changes

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achingbrain @vmx @rvagg