-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Standardize Stream Naming #1916
Comments
@freearhey @Daniel15 what do you think? @link8k @lanesh4d0w thoughts? |
I had began doing the HD / SD options, but I agree that Example 3 would be more fitting. I'll have a look on the definitions and change them once I got them. |
Maybe @freearhey could make some magic on his IPTV checker, regarding the bitrate/definition of the stream. Normally, bitrate is mentioned on stream data info, if it isn't then FFProbe can backup. |
Changed example to scenario, hope that makes things more clear. |
An extreme case could look like this.
|
Well, all three options are valid. Occasional could be misleading, because we could take the scenario that some channels (in very rare cases) could stream on random dates (could also be linked to server issues). Part-time could indicate more precisely that the mentioned channel has got a certain schedule, and does not stream 24/7. |
If possible, could this issue be pinned ? It's considered important IMO, because this will be an effective convention on channel naming. |
@themak1985 Good suggestion! I also thought about this and the only thing I decided was to exclude "Backup/Backup1/etc" label from the channel name. The problem with it is that when you remove one link, you have to edit the name of all the other links to the same channel to keep the order and it slows down the process a lot especially when there are hundreds of links. For the rest, I agree with you. As for automatic detection of broadcast quality, I will try to study this subject in the next couple of days and let you know. |
Cool :) I can take a look if needed, I got some JS skills up my sleeve. |
Good point about the backup. Maybe we just adopt the time shift, constant bitrates, and part-time naming convention. |
Here's what I was able to find out. Many streams do contain additional information including resolution, here's what it usually looks like:
If the stream is available in more than one resolution, the data looks like this:
Based on that, I decided to add a parser to
the script just skips it. Here are the results: 234ab38 Also in the process it turned out that parentheses are often used to specify an alternative name, for example:
and it would be more convenient to put all extra notes in square brackets and at the very end, like so:
The script already supports this syntax, but I can change it if needed. |
I also was thinking about something. We got radios on our IPTV streams. Could it be better to create a category that references all of them ? I'll add something more. When we count the number of channels available, we should not count the backup ones, as it could falsify the final number. |
@themak1985 I propose the following scheme:
The most complete example:
|
Maybe we could add a GitHub actions script that triggers the parser, to verify if data is correct. As an example : someone adds a stream on PR. Parser is triggered and could say : "Info OK" or "Warning : <Given resolution is 1920x1080, found 740x246>" |
About the sd/hd thing, here's what I propose: Don't put SD in a channel name, but put (HD), (FHD), (UHD) etc in brackets if the channel's broadcast quality is anything above SD Example: Example TV That way it wouldn't be so confusing for people when they look through the channels if they only wanted standard quality. If they were noobish they may mistake (SD) for high-definition or something, or might assume the channel doesn't broadcast in standard definition at all when it actually does. The "example TV" would be for the standard quality, or the stream playlist file that lists all qualities. The rest is self-explanatory. |
@trancer1994 I like this idea. As for broadcasts with adaptable quality, I think it would be better to specify the highest one. |
I think the ultimate goal here is not to have bitrate information for every stream but to differentiate multiple streams of the same channel. I also think bitrate is a better approach over naming. 1080P>FHD |
To be honest, there are also "fake HD" streams (bitrate going close to 1080p isn't a real HD stream) |
@freearhey I think this is safe to close now right? |
@themak1985 don't you want to discuss @trancer1994's suggestion to use HD, FHD? I know you've thought about this option before, but you were stopped by the fact that some channels are broadcast in non-standard resolution. For example, we could do this:
In the current version, whatever the resolution is, it will be written in the channel name and most of the time it's I'm really curious what you think about that. |
@freearhey Not a bad idea, but I would say less than 480p => Example TV (SD) Its less accurate than what we have now but to end user, might be nicer to see. Also we just leave adaptive as blank right or do we choose the highest possible stream? |
I studied the playlists more closely and noticed that the label "HD" is often part of the official name of the channels. So if we start adding to them more labels like SD, HD, FHD it can cause even more confusion. For example:
So I think it would be better to keep the 480p/720p/1080p option for now. But if something changes in the future we will discuss this topic again. |
Is your feature request related to a problem? Please describe.
Sometimes we have numerous streams for one channel. The streams sometimes have adaptive or constant bitrates. Some are backups, some are part time broadcasts. What ends up happening is that we will have numerous streams for one channel with no differentiating factors.
Describe the solution you'd like
Using
Example TV
for channel name in scenarios.Scenario 1: Two adaptive streams for same channel
Scenario 2: Multiple Streams, main and backups are adaptive, others are constant bitrates.
Scenario 3: Multiple streams, no adaptive links, multiple bitrates.
(We could choose to simply place highest bitrate as main channel, in this example, 2160P would just be listed as
Example TV
)Scenario 4: Part-time streams - I have three different options, we should pick one.
Scenario 5: Channels with time-shifts. (Not common here, but good to standardize.)
In example above, +5 and -4 represent hours difference from main stream.
Scenario 6: Single channel
Example TV
(Might be obvious, but no bitrate information should be added even if not adaptive)
Describe alternatives you've considered
I considered using terms like SD, HD, FHD, QHD, 2K, 4K, etc, but there are bitrates that do not adhere to these categories.
Additional context
I don't think we have to update all playlists if/when this is adopted, but we should add this information when finalized to contributing guide.
The text was updated successfully, but these errors were encountered: