Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forum topics create/edit/close/reopen/delete #1122

Merged
merged 11 commits into from
Apr 3, 2024

Conversation

makkmarci13
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 41.84%. Comparing base (c72ef58) to head (1775323).
Report is 2 commits behind head on 3.x.

Files Patch % Lines
src/Methods/Forum.php 0.00% 11 Missing ⚠️
src/Objects/ForumTopic.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x    #1122      +/-   ##
============================================
- Coverage     42.15%   41.84%   -0.31%     
- Complexity      608      614       +6     
============================================
  Files           131      133       +2     
  Lines          1784     1797      +13     
============================================
  Hits            752      752              
- Misses         1032     1045      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makkmarci13
Copy link
Contributor Author

What I need to do to solve this 2 check?

@irazasyed
Copy link
Owner

Add tests please

@makkmarci13
Copy link
Contributor Author

I made some, these are okey?

@irazasyed
Copy link
Owner

Please fix the tests

@makkmarci13
Copy link
Contributor Author

I think i fixed it

@irazasyed
Copy link
Owner

@makkmarci13 Please run tests in your local env and fix them. Push the final patch!

@makkmarci13
Copy link
Contributor Author

image

For me, now runs.

@makkmarci13
Copy link
Contributor Author

So now what should I do?

@irazasyed
Copy link
Owner

Your tests are invalid. Just remove it for now and I'll merge.

@irazasyed irazasyed merged commit a24ba59 into irazasyed:3.x Apr 3, 2024
7 of 9 checks passed
@irazasyed
Copy link
Owner

Thanks

@sathio
Copy link

sathio commented May 7, 2024

Hi, I'd need this file it looks like it's not on the latest version. can it be included please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants