[Codegen][GPU] Add tiling cleanup pattern to fuse pad without zero gaurd #18748
+76
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groverkss
requested review from
MaheshRavishankar,
qedawkins,
kuhar and
antiagainst
as code owners
Groverkss
force-pushed
the
pad-remove-zero-slice-gaurd
branch
from
6500ec4
to
6fe4866
Compare
kuhar
reviewed
Oct 10, 2024
compiler/src/iree/compiler/Codegen/Common/GPU/GPUApplyTilingLevel.cpp
Outdated
Show resolved
Hide resolved
Groverkss
force-pushed
the
pad-remove-zero-slice-gaurd
branch
from
6fe4866
to
909bbbd
Compare
Groverkss
force-pushed
the
pad-remove-zero-slice-gaurd
branch
from
aa41f7d
to
6d37322
Compare
qedawkins
approved these changes
Oct 14, 2024
compiler/src/iree/compiler/Codegen/Common/GPU/GPUApplyTilingLevel.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/GPU/GPUApplyTilingLevel.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to fuse tensor.pad in ApplyGPUTilingLevel when we know the pad will not ever recieve an empty slice. This is useful, when the tensor.pad is padding to the tiling size that we are tiling with, and will never generate an empty slice.