chore: improves logging to find a hidden NPE

iris-connect · May 4, 2022 · 6ae7c6b · 6ae7c6b
1 parent 41f56d1
commit 6ae7c6b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/iris-client-bff/src/main/java/iris/client_bff/status/eps/EPSStatusClient.java b/iris-client-bff/src/main/java/iris/client_bff/status/eps/EPSStatusClient.java
@@ -42,6 +42,7 @@ public Apps getAvailableApps() {
 
  return epsRpcClient.invoke(methodName, null, Directory.class).entries().stream()
  .filter(directoryEntry -> directoryEntry.groups().contains("checkin-apps"))
+ .peek(System.out::println)
  .map(DirectoryEntry::name)
  .map(App::new)
  .collect(collectingAndThen(toList(), Apps::new));

diff --git a/iris-client-bff/src/main/java/iris/client_bff/status/web/AppStatusController.java b/iris-client-bff/src/main/java/iris/client_bff/status/web/AppStatusController.java
@@ -8,6 +8,7 @@
 import iris.client_bff.status.web.AppStatusController.AppStatusInfo.Info;
 import lombok.AllArgsConstructor;
 import lombok.Value;
+import lombok.extern.slf4j.Slf4j;
 
 import java.util.List;
 
@@ -27,6 +28,7 @@
 @RequestMapping("/status/checkin-apps")
 @Validated
 @AllArgsConstructor
+@Slf4j
 public class AppStatusController {
 
  private StatusService statusService;
@@ -37,6 +39,9 @@ public List<App> getApps() {
  try {
  return statusService.getApps().toList();
  } catch (Exception e) {
+
+ log.error("Can't get apps from StatusService: ", e);
+
  throw new ResponseStatusException(HttpStatus.BAD_REQUEST, e.getMessage());
  }
  }