Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamusers: use new ruri_domain for static location (retail, residential and friends) #2640

Merged
merged 1 commit into from
May 10, 2024

Conversation

cruzccl
Copy link
Member

@cruzccl cruzccl commented Apr 29, 2024

Type Of Change

  • Small bug fix
  • New feature or enhancement
  • Breaking change

Checklist:

  • Commits are named and have tag following commit rules
  • Commits are split per component (schema, web/admin, kamusers, agis, ..)
  • Changes have been tested locally
  • Fixes an existing issue (Fixes #XXXX)
  • Upport from existing Pull request #XXXX

Description

Static location friends, retail accounts and residential devices now have a new field ruri_domain. This PR uses this new field to route requests properly.

Additional information

3 kind of static location routing from now on:

  • ruri_domain + ip/port: ip/port will act as outbound-proxy and R-URI domain will be used in R-URI header domain.
  • ruri_domain without ip/port: no outbound-proxy, ruri_domain used in R-URI will be used to route the request.
  • ip/port without ruri_domain: behaviour prior to this PR. ip/port will be set in R-URI.

@cruzccl cruzccl added +feature New feature users SIP Users Proxy ci-no-tests Do not run test for this Pull Request *tempest* IvozProvider 4.x Tempest Release labels Apr 29, 2024
@cruzccl cruzccl added this to the 4.1.0 milestone Apr 29, 2024
@cruzccl cruzccl requested a review from Kaian April 29, 2024 14:15
@cruzccl cruzccl self-assigned this Apr 29, 2024
@cruzccl cruzccl force-pushed the PROVIDER-1805-ruri-domain-static-location branch from 84d32ee to 4325f4f Compare May 8, 2024 12:29
@cruzccl cruzccl force-pushed the PROVIDER-1805-ruri-domain-static-location branch from 4325f4f to 3297304 Compare May 9, 2024 10:30
@cruzccl cruzccl marked this pull request as ready for review May 9, 2024 11:07
@cruzccl cruzccl merged commit 9f2a139 into bleeding May 10, 2024
2 checks passed
@cruzccl cruzccl deleted the PROVIDER-1805-ruri-domain-static-location branch May 10, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-tests Do not run test for this Pull Request +feature New feature *tempest* IvozProvider 4.x Tempest Release users SIP Users Proxy
Development

Successfully merging this pull request may close these issues.

2 participants