Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage direct connectivity at brand level #2650

Merged
merged 6 commits into from
May 17, 2024
Merged

Manage direct connectivity at brand level #2650

merged 6 commits into from
May 17, 2024

Conversation

danigargar
Copy link
Contributor

@danigargar danigargar commented May 9, 2024 •
edited
Loading

Type Of Change

  • Small bug fix
  • New feature or enhancement
  • Breaking change

Checklist:

  • Commits are named and have tag following commit rules
  • Commits are split per component (schema, web/admin, kamusers, agis, ..)
  • Changes have been tested locally
  • Fixes an existing issue (Fixes #XXXX)
  • Upport from existing Pull request #XXXX

Description

Additional information

@danigargar danigargar requested a review from mmadariaga May 9, 2024 14:18
@danigargar danigargar force-pushed the PROVIDER-1837-manage-direct-connectivity-at-brand-level branch 4 times, most recently from 83e03e9 to ee72b78 Compare May 9, 2024 15:39
@danigargar danigargar self-assigned this May 10, 2024
@danigargar danigargar changed the title Provider 1837 manage direct connectivity at brand level Manage direct connectivity at brand level May 10, 2024
@danigargar danigargar added this to the 4.1.0 milestone May 13, 2024
@danigargar danigargar added core Core Libraries portal/client Client portal portal/brand Brand portal tests Test +enhancement Enhancement labels May 13, 2024
@mmadariaga mmadariaga force-pushed the PROVIDER-1837-manage-direct-connectivity-at-brand-level branch from ee72b78 to 5b726f3 Compare May 14, 2024 06:42
@danigargar danigargar force-pushed the PROVIDER-1837-manage-direct-connectivity-at-brand-level branch from 5b726f3 to 6d18bd5 Compare May 14, 2024 06:53
@Kaian Kaian force-pushed the PROVIDER-1837-manage-direct-connectivity-at-brand-level branch from 6d18bd5 to 33b65a9 Compare May 15, 2024 11:02
ironArt3mis
ironArt3mis requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@ironArt3mis ironArt3mis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review required

@Kaian Kaian force-pushed the bleeding branch 2 times, most recently from 9fd32d6 to b5a5198 Compare May 15, 2024 14:01
@cruzccl cruzccl force-pushed the PROVIDER-1837-manage-direct-connectivity-at-brand-level branch from 33b65a9 to e468831 Compare May 17, 2024 07:41
@danigargar danigargar merged commit fb7ef8a into bleeding May 17, 2024
17 checks passed
@danigargar danigargar deleted the PROVIDER-1837-manage-direct-connectivity-at-brand-level branch May 17, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmadariaga mmadariaga mmadariaga approved these changes

@ironArt3mis ironArt3mis ironArt3mis approved these changes

Assignees

@danigargar danigargar

Labels
core Core Libraries +enhancement Enhancement functional-review portal/brand Brand portal portal/client Client portal tests Test
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@danigargar @mmadariaga @ironArt3mis