microservices/recordings: use hashid for temporal MP3 filename #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaian
added
+bug
danigargar
approved these changes
Jul 26, 2024
Before this change, Call-Id header value was used for the temporal mp3 file of recordings. This value can contain characters that breaks the avconv command (like '/') so, we could encode this value or just replace it for another one. This is a temporal file that will be deleted by FSO core logic, so the easiest was to change its value to hashid, a partial md5 of Call-Id.
Kaian
force-pushed
the
PROVIDER-1943-microservice-recordings-temp-mp3-filename
branch
from
2b8dd6b
to
97cda00
Compare
Kaian
deleted the
PROVIDER-1943-microservice-recordings-temp-mp3-filename
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type Of Change
Checklist:
Description
Before this change, Call-Id header value was used for the temporal mp3 file of recordings. This value can contain characters that breaks the avconv command (like '/') so, we could encode this value or just replace it for another one. This is a temporal file that will be deleted by FSO core logic, so the easiest was to change its value to hashid, a partial md5 of Call-Id.
Additional information