Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agis: fix on demand record code on simple huntgroups #2759

Merged

Conversation

Kaian
Copy link
Member

@Kaian Kaian commented Sep 6, 2024

Type Of Change

  • Small bug fix
  • New feature or enhancement
  • Breaking change

Checklist:

  • Commits are named and have tag following commit rules
  • Commits are split per component (schema, portal/platform, kamusers, agis, ..)
  • Changes have been tested locally
  • Fixes an existing issue (Fixes #XXXX)
  • Upport from existing Pull request #XXXX

Description

To enable builtin automixmon features, Dial application require xX flags (most probably only x is required) and also setting the DTMF code including * in "FEATUREMAP(automixmon)" variable.

This PR add the missing options to Dial used by simple HuntGroups and fixes the code not having the * prefix proprely defined in feature map variable.

Additional information

@Kaian Kaian self-assigned this Sep 6, 2024
@Kaian Kaian added +bug Bug agis Asterisk Gateway Interface *tempest* IvozProvider 4.x Tempest Release labels Sep 6, 2024
@Kaian Kaian added this to the 4.2.0 milestone Sep 6, 2024
@Kaian Kaian force-pushed the PROVIDER-2025-fix-on-demand-record-simple-huntgroups branch 2 times, most recently from d6412dd to f22b6cf Compare September 9, 2024 09:46
@Kaian Kaian changed the base branch from bleeding to PROVIDER-1945-use-provider-tables September 9, 2024 09:46
@cruzccl cruzccl force-pushed the PROVIDER-1945-use-provider-tables branch from fdfaee5 to 52f0947 Compare September 9, 2024 09:55
@cruzccl cruzccl force-pushed the PROVIDER-2025-fix-on-demand-record-simple-huntgroups branch from f22b6cf to 57f9b19 Compare September 9, 2024 09:59
Copy link
Contributor

@ironArt3mis ironArt3mis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review required

@cruzccl cruzccl force-pushed the PROVIDER-1945-use-provider-tables branch from 52f0947 to c92ed98 Compare September 9, 2024 15:21
Base automatically changed from PROVIDER-1945-use-provider-tables to bleeding September 9, 2024 15:31
@cruzccl cruzccl force-pushed the PROVIDER-2025-fix-on-demand-record-simple-huntgroups branch from 57f9b19 to 06f6b2b Compare September 9, 2024 15:33
@Kaian Kaian merged commit fbaf752 into bleeding Sep 9, 2024
2 checks passed
@Kaian Kaian deleted the PROVIDER-2025-fix-on-demand-record-simple-huntgroups branch September 9, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agis Asterisk Gateway Interface +bug Bug functional-review *tempest* IvozProvider 4.x Tempest Release
Development

Successfully merging this pull request may close these issues.

3 participants