Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar.extract silently exits and writes 0 bytes #232

Closed
skeet70 opened this issue Sep 23, 2019 · 1 comment
Closed

tar.extract silently exits and writes 0 bytes #232

skeet70 opened this issue Sep 23, 2019 · 1 comment

Comments

@skeet70
Copy link

skeet70 commented Sep 23, 2019

Investigating mapbox/node-pre-gyp#477.

This extract call doesn't emit close/error/finish and leads to a higher level exit being called. The onentry call does happen, but looking at the disk after everything exits, nothing was actually extracted.

ls -l bin-package/
total 0
-rw-rw-r-- 1 travis travis 0 Sep 23 20:53 index.node

Seems like this is directly related to isaacs/minipass#9

@isaacs
Copy link
Owner

isaacs commented Sep 24, 2019

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants