Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yanggangtony to istio member list #1078

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Add yanggangtony to istio member list #1078

merged 1 commit into from
Jun 10, 2023

Conversation

yanggangtony
Copy link
Member

@yanggangtony yanggangtony commented Jun 9, 2023 •
edited by zirain
Loading

I want to join the Istio org!

I am a k8s and k8s-sigs member , and i like istio too. And want to contribute more in the future.

The pr i commit for istio is the link
istio prs

istio/istio#42575

@yanggangtony yanggangtony requested a review from a team as a code owner June 9, 2023 08:36
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jun 9, 2023
@istio-testing
Copy link
Contributor

Hi @yanggangtony. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zirain
zirain previously approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@zirain
Copy link
Member

zirain commented Jun 9, 2023

/ok-to-test

zirain
zirain reviewed Jun 9, 2023
View reviewed changes
org/members.yaml
@@ -416,6 +416,7 @@ members:
- Xunzhuo
- yangminzhu
- yankay
- yanggangtony
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort in alphabetical order

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.
Rebased.

@zirain zirain added the do-not-merge Block automatic merging of a PR. label Jun 9, 2023
@yanggangtony
Copy link
Member Author

/retest

@zirain zirain removed the do-not-merge Block automatic merging of a PR. label Jun 10, 2023
@istio-testing istio-testing merged commit d61bc0a into istio:master Jun 10, 2023
@yanggangtony
Copy link
Member Author

Thanks very much..

@yanggangtony yanggangtony deleted the member branch June 15, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

Assignees
No one assigned
Labels
ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanggangtony @istio-testing @zirain