[Issuance flow]: added error management #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
reviewed
Mar 2, 2024
peppelinux
requested changes
Mar 2, 2024
| * - **c_nonce_expires_in** | ||
| - JSON integer corresponding to the **c_nonce** lifetime in seconds. | ||
| - `[OIDC4VCI. Draft 13] <https://openid.bitbucket.io/connect/openid-4-verifiable-credential-issuance-1_0.html>`_. | ||
| - `[OIDC4VCI. Draft 13] <https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html>`_. |
There was a problem hiding this comment.
vedo questo link riportato spesso, che ne pensi se registrassimo un tag e andassimo by ref?
There was a problem hiding this comment.
Sì ci avevo pensato anche perché sarebbe più comodo nel caso di eventuali future modifiche della url. Appena riesco lo faccio
Comment on lines
+954
to
+957
| If the Credential Request is invalid, the PID/(Q)EAA Provider MUST return an error response as defined in `[OIDC4VCI. Draft 13] <https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#section-7.3.1.2>`. The response MUST use the content type *application/json* and MUST include the following parameters: | ||
|
|
||
| - *error*. The error code. | ||
| - *error_description*. Text in human-readable form providing further details to clarify the nature of the error encountered. |
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
balanza
approved these changes
Mar 4, 2024
peppelinux
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
[Issuance flow]: added error management
Content
In this PR I clarify how to handle the HTTP Error Response in case of an invalid
I also fixed some typos (link to the OID4VCI, reference to a table) and I made some minor editorial fixes.
This PR closes #139
Review