Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors that might occur during the presentation #226

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Errors that might occur during the presentation #226

merged 4 commits into from
Mar 4, 2024

Conversation

peppelinux
Copy link
Member

this PR aims to close #224

since we still don't have the required details in the openid4vp specs, I propose a relaxed language and generic error identifiers.

I hope that this little step might help the discussion within the openid working group.

@peppelinux
Copy link
Member Author

See also
openid/OpenID4VP#120

docs/en/remote-flow.rst Outdated Show resolved Hide resolved
docs/en/remote-flow.rst Outdated Show resolved Hide resolved
Co-authored-by: Giada Sciarretta <[email protected]>
@peppelinux peppelinux requested a review from giadas March 3, 2024 19:33
Copy link
Collaborator

@fmarino-ipzs fmarino-ipzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed a couple of editorial issues (the figure was not displayed correctly in the document and a dot was missing in the warning section resulting in a block comment of the text below).

@peppelinux peppelinux merged commit eb75a03 into rpwa Mar 4, 2024
8 of 9 checks passed
peppelinux added a commit that referenced this pull request Mar 5, 2024
* fix!: alignments according to breaking changes introduced by openid4vci I-D

* RP WTE in PE and Entity Configuration base

* fix: RP presentation with client_id_scheme and request_uri_method within the qrcode/redirect url

* fix: RP presentation with client_id_scheme and request_uri_method using post

* fix: RP presentation defintiion with WTE with exp and iat as constraints

* RP Giada's revision

* RP state definition

* Apply suggestions from code review

Co-authored-by: Giada Sciarretta <[email protected]>

* RP seq diag svg aligned

* Errors that might occur during the presentation (#226)

* RP errors

* Apply suggestions from code review

Co-authored-by: Giada Sciarretta <[email protected]>

* fix: figure visualization issue

* fix: editorial

---------

Co-authored-by: Giada Sciarretta <[email protected]>
Co-authored-by: fmarino-ipzs <[email protected]>

* fix: renamed Wallet Trust Evidence in Wallet Attestation

* Apply suggestions from code review

Co-authored-by: Francesco Grauso <[email protected]>

---------

Co-authored-by: Giada Sciarretta <[email protected]>
Co-authored-by: fmarino-ipzs <[email protected]>
Co-authored-by: Francesco Grauso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants