Fix non-normative example of HTTP response in the Presentation Remote Flow #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
approved these changes
Jul 8, 2024
peppelinux
reviewed
Jul 8, 2024
|
|
||
| { | ||
| "redirect_uri": "https://relying-party.example.org/cb#response_code=091535f699ea575c7937fa5f0f454aee" | ||
| "redirect_uri": "https://relying-party.example.org/cb?response_code=091535f699ea575c7937fa5f0f454aee" |
There was a problem hiding this comment.
the reasn why it was a fragment is to allow the registration of the redirect_uris in the metadata and using fragments to allow randomization of the endpoints
There was a problem hiding this comment.
Please, see also node-fetch/node-fetch#211
There was a problem hiding this comment.
openid4vp non-normative example uses the fragment
https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-6.2-22
peppelinux
added
breaking change
standardization
grausof
approved these changes
Jul 24, 2024
fmarino-ipzs
commented
Jul 24, 2024
peppelinux
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Content
Closes #355
Review