fs: introduce tree.find() #5878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
commented
Apr 26, 2021
| # directories since they are represented as files. This condition | ||
| # checks whether we should yield an empty list (if it is an empty | ||
| # directory) or just yield the file itself. | ||
| if len(files) == 1 and files[0] == path and self.isdir(path_info): |
There was a problem hiding this comment.
This check is intentionally omitted from the bare ls() since its main objective is to support directory listing when calling walk_files() and I didn't want to repeat it in 2 different places.
isidentical
commented
Apr 26, 2021
| def walk_files(self, path_info, **kwargs): | ||
| # Check whether directory exists | ||
| if not self.exists(path_info): |
There was a problem hiding this comment.
This seemed like a legacy check since none of the other implementations calls exists() before walk_files() (even the ones that doesn't raise proper errors like s3 etc, I am not sure whether it is still needed or not)
|
🤦🏻♀️ pushed branch to the wrong repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved to upstream branch #5879