Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux build fails with "No rule to make target `../../src/core/PolyCoreServices.o'" #699

Open
BinRoot opened this issue Aug 3, 2016 · 5 comments

Comments

@BinRoot
Copy link

BinRoot commented Aug 3, 2016

I'm on goodbye_cmake 670e1d11ad
Here's what I did:

$ cd build/linux
$ make all

Here's the log:

Building [../../src/core/lodepng.cpp]
Building [../../src/core/PolyBasicFileProvider.cpp]
Building [../../src/core/PolyBezierCurve.cpp]
Building [../../src/core/PolyBone.cpp]
Building [../../src/core/PolyCamera.cpp]
Building [../../src/core/PolyClient.cpp]
Building [../../src/core/PolyColor.cpp]
Building [../../src/core/PolyConfig.cpp]
../../src/core/PolyConfig.cpp: In member function ‘const Polycode::String& Polycode::Config::getStringValue(const Polycode::String&, const Polycode::String&) const’:
../../src/core/PolyConfig.cpp:135:10: warning: returning reference to temporary [-Wreturn-local-addr]
   return "undefined";
          ^
Building [../../src/core/PolyCore.cpp]
Building [../../src/core/PolyCoreFileProvider.cpp]
Building [../../src/core/PolyCoreInput.cpp]
make: *** No rule to make target `../../src/core/PolyCoreServices.o', needed by `core'.  Stop.
@fodinabor
Copy link
Contributor

Hey,
yes the problem is we have not yet updated any other distros than Mac & Windows... coming soon - but if you can't wait have a look at which files have been removed in 4992d52
and remove them from the makefile as well.

@BinRoot
Copy link
Author

BinRoot commented Aug 3, 2016

Seems like PolySDLCore.cpp is no longer supposed to be used, but it's tangled up in the linux version

@fodinabor
Copy link
Contributor

Uhmm.. It's still used on Linux - but that has to be updated as well..

@ghost
Copy link

ghost commented Sep 3, 2016

@fodinabor Do you have a fix in an upcoming commit? I did somewhat of a fix I can push, but if you have one I can leave it be.

@fodinabor
Copy link
Contributor

@sanghakchun goodbye_cmake...fodinabor:goodbye_cmake is my latest changes.. but I guess it does not affect SDL Core - so you are welcome to send your own PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants