Add ability to reload config files #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The load is externalized into a dedicated public method so we can reload config files after a custom creation of a config file.
- Config files are loaded when the class is instancied.
- If we add a new file after, it won't be loaded.
- We'll need to manually reload config files
It’s usefull when we provide an interface to allow the user to define a custom site config (to test some rules for example)
j0k3r
force-pushed
the
reload-config-files
branch
from
0fb7d5d
to
6e28b6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load is externalized into a dedicated public method so we can reload config files after a custom creation of a config file.
It’s usefull when we provide an interface to allow the user to define a custom site config (to test some rules for example)