Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient: refactor the way we clean utm_ query params #276

Merged
merged 3 commits into from
Dec 13, 2021
Merged

HttpClient: refactor the way we clean utm_ query params #276

merged 3 commits into from
Dec 13, 2021

Commits on Dec 11, 2021

  1. HttpClient: refactor the way we clean utm_ query params 

    The old preg_replace call incorrectly removed the ? of the query string
section which could lead to things like this:

  http://example.com/foo?utm_source=a&var=value =>
http://example.com/foo&var=value

Signed-off-by: Kevin Decherf <[email protected]>
    @Kdecherf
    Kdecherf committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    cf725b1 View commit details
    Browse the repository at this point in the history

  2. tests: fix tests following query string refactor 

    As per RFC3986, Section 3.4 indicates that we can avoid percent-encoding
the'/' and '?' characters. However the '=' character in the nested query
string should be encoded.

Signed-off-by: Kevin Decherf <[email protected]>
    @Kdecherf
    Kdecherf committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    5fab669 View commit details
    Browse the repository at this point in the history

  3. dependencies: set min version of guzzlehttp/psr7 to 1.5.0 

    Uri::withQueryValues() has been added in psr7 1.5.0 but our direct
dependency http-factory-guzzle is currently set to require ^1.4.2 which
could cause issues on some installations.

Signed-off-by: Kevin Decherf <[email protected]>
    @Kdecherf
    Kdecherf committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    d8f93d9 View commit details
    Browse the repository at this point in the history