Update codebase to support Readability 2 #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kdecherf
force-pushed
the
readability-2
branch
from
bce4afa
to
0904911
Compare
The dom property is initialized by Readability::loadHtml() which has been moved from __construct() to init() in v2; thus we must call init() early. We also remove the previous init() call to prevent any issues as it is not idempotent. Signed-off-by: Kevin Decherf <[email protected]>
The stripping of invisible elements is now done by Readability 2 Signed-off-by: Kevin Decherf <[email protected]>
Signed-off-by: Kevin Decherf <[email protected]>
Signed-off-by: Kevin Decherf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.