Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly removes CSS variables #323

Closed
ghost opened this issue Jul 25, 2014 · 2 comments
Closed

Incorrectly removes CSS variables #323

ghost opened this issue Jul 25, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 25, 2014

Example:

.wrapper { --border: black; }
#navigation div { border: 1px solid var(--border) }

In this case, the variable can still be valid if #navigation is inside .wrapper. However, clean-css assumes that it's invalid and outputs .wrapper{--border:#000}#navigation div{border:1px solid}, which is wrong. Oddly enough, it seems to leave other variable uses alone.
@GoalSmashers
Copy link
Contributor

We're on it! Please use --skip-advanced in the meantime.

GoalSmashers pushed a commit that referenced this issue Jul 27, 2014
@jakubpawlowicz
Fixes #323 - variable references being stripped out.
ab30cc9 
* Advanced optimizations haven't supported CSS variables.
@GoalSmashers
Copy link
Contributor

Fixed in 2.2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoalSmashers