Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Losing padding style with advanced: true #452

Closed
adamschwartz opened this issue Feb 4, 2015 · 6 comments
Closed

Bug: Losing padding style with advanced: true #452

adamschwartz opened this issue Feb 4, 2015 · 6 comments
Labels
bug

Comments

@adamschwartz
Copy link

In v3.0.8, the this CSS:

header,
footer {
  padding-top: 1.25em;
  padding-bottom: 1.25em;
}
header {
  padding-top: 2.5em;
}
footer {
  padding-bottom: 2.5em;
}

minifies to:

footer,header{padding-top:1.25em}header{padding-top:2.5em}footer{padding-bottom:2.5em}

Essentially the rule padding-bottom: 1.25em; is omitted.
@jakubpawlowicz
Copy link
Collaborator

That's interesting indeed. Fix is coming!

@adamschwartz
Copy link
Author

Thanks @jakubpawlowicz!

Haha yeah, I’m curious what the fix will look like. 😜

@jakubpawlowicz
Copy link
Collaborator

It's fine in 2.2 though.

jakubpawlowicz added a commit that referenced this issue Feb 4, 2015
@jakubpawlowicz
Fixes #452 - regression in non-adjacent merging.
dfc566b 
It's a regression from 2.2 as we added a smarter merging but it
does not always correctly compare arrays (bloody JavaScript ;-).
@jakubpawlowicz
Copy link
Collaborator

@adamschwartz Fixed in 3.0.9 - here's the fix 612219e#diff-99a30d068c42b4f98cbbb103231cc2eaL225 kinda backported from 2.2.

@adamschwartz
Copy link
Author

Awesome. Thanks so much! 👍

@jakubpawlowicz
Copy link
Collaborator

Sure thing. Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakubpawlowicz @adamschwartz