-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE hack issue #556
Comments
/CC @cvrebert since it's apparently the reason for twbs/bootstrap@d0926f2 |
Interestingly, if you put a space before the backslash, clean-css leaves the 9 intact. |
@cvrebert: I guess we could add the space until this is sorted then? What I don't get is why we see the difference between the bot and my local tree. I mean, we do use the same clean-css version with the same settings and all. |
It's the styling any different when you use \0 instead of \9? |
@jakubpawlowicz: IIRC |
Yeah, |
Oh, wow 🤦 |
Fixed in 3.2.6. |
Thanks! |
Hi, thanks for the great library! I think this fix has caused a side effect. Both
This is the output:
As you can see Also, is there an option that I can turn off to stop replacing I've made a test case here http://jsbin.com/vowalixoku and you can test it in different IE version by pasting that URL here http://netrenderer.com/index.php Thanks |
@vladimirsiljkovic I wasn't aware of this side effect. Let's fix it. |
Apparently turning all backslash hacks into `\9` hack is not desirable strategy, as, for example, `\0` hack has a different meaning.
Apparently turning all backslash hacks into `\9` hack is not desirable strategy, as, for example, `\0` hack has a different meaning.
Apparently turning all backslash hacks into `\9` hack is not desirable strategy, as, for example, `\0` hack has a different meaning.
@vladimirsiljkovic it's fixed in 4.0.10. |
Great! Thank you, @jakubpawlowicz. Just to confirm that it's working for me with these settings:
|
Thanks for rechecking @vladimirsiljkovic - you can also turn on all IE8+ compatibility with |
Using clean-css v3.2.5, node.js 0.12.2 on Windows 7 64-bit:
source:
output:
\9
becomes\0
.The text was updated successfully, but these errors were encountered: