Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background: inherit expansion #563

Closed
gpbmike opened this issue May 5, 2015 · 4 comments
Closed

background: inherit expansion #563

gpbmike opened this issue May 5, 2015 · 4 comments
Labels
Milestone

Comments

@gpbmike
Copy link

gpbmike commented May 5, 2015

A user on my site (http://refresh-sf.com) noticed that when minifying a class with background: inherit it is expanded to cover all background properties

div{background:inherit;} -> div{background:inherit inherit/inherit inherit inherit inherit}

I wanted to see if this was intentional or not?

@jakubpawlowicz
Copy link
Collaborator

Oh, it's definitely not. Good catch!

@eduardocasas
Copy link

Same problem here.

By the way, this bug can be skipped using background-* properties instead of backgound shorthand.

@jakubpawlowicz
Copy link
Collaborator

It's fixed in 3.3-pre master. I'm considering backporting it to 3.2 too.

@gpbmike
Copy link
Author

gpbmike commented May 20, 2015

Thank you kind sir. 👍

@jakubpawlowicz jakubpawlowicz added this to the 3.3 milestone May 20, 2015
jakubpawlowicz added a commit that referenced this issue May 31, 2015
Restoring inherit background were done incorrectly (to expanded form).
jakubpawlowicz added a commit that referenced this issue Jun 24, 2015
Apparently `withoutDefaults` restoring suffered the same issue as
`background` property restoring - see #563.
jakubpawlowicz added a commit that referenced this issue Jun 24, 2015
Apparently `withoutDefaults` restoring suffered the same issue as
`background` property restoring - see #563.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants