Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged rules with ::placeholder pseudo-selectors broken in v3.3.7 #634

Closed
rolang opened this issue Aug 4, 2015 · 1 comment
Closed

Merged rules with ::placeholder pseudo-selectors broken in v3.3.7 #634

rolang opened this issue Aug 4, 2015 · 1 comment
Labels

Comments

@rolang
Copy link

rolang commented Aug 4, 2015

This one looks similar to #561

.some-element {
    color: #d72319;
}
.some-other-element::placeholder {
    color: #d72319;
}

Gets merged to:

.some-element,.some-other-element::placeholder{color:#d72319}

which breaks the rule.

Should be:

.some-element{color: #d72319}.some-other-element::placeholder{color:#d72319}
@jakubpawlowicz
Copy link
Collaborator

We should treat ::placeholder selector as special too, see https:/jakubpawlowicz/clean-css/blob/master/lib/utils/compatibility.js#L23

jakubpawlowicz added a commit that referenced this issue Aug 6, 2015
:placeholder is also not widely supported (IE10+) so we need to
skip merging it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants