-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media query and newline character after @media #66
Comments
Update: It looks like just simply adding a single space after the |
Thanks @mhulse for reporting this. If your CSS renders correctly (and I assume it does) when there's a newline after |
@GoalSmashers Cool! Thanks for getting back to me so quickly! I really appreciate it. From what I have tested, the (unminified) MQ works without a space after the I'll do some more tests and let you know if I discover anything different. For now, adding that space after Thanks again! |
Sure, no problem! Let us know how does it behave. We'll fix it anyway! |
@mhulse - it has been fixed in 0.10.1 which has just landed in npm repository. |
Whoa! That was quick!!! Thanks so much for the fix @GoalSmashers, I really appreciate it!!! I owe you one. :) Also, thanks for the awesome code! Have a great day. Cheers, |
There were no reasons to wait! Happy minifying! Cheers, |
Hi,
This is not so much a bug, but more of an FYI to anyone else in the same boat.
Take this media query for example:
When minified (using Grunt's mincss task) the
@media
andonly
get mushed together:@mediaonly ...
When I put the media query on the same line:
The media query minifies without any problems.
Speaking strictly in terms of CSS, I'm not sure if it's syntactically incorrect to put the
only
on a newline after the@media
, so that's why I figure this is not a bug ... It's easy enough to add a space after the@media
or put the MQ all on one line.Just thought this info might help someone and/or the
clean-css
crew would like to know?Not sure if I should keep this issue open or closed. Feel free to close it if you think this is not a bug (or, I'll come back by in a week to close it myself).
Keep up the excellent work!
Thanks!
Micky
The text was updated successfully, but these errors were encountered: