Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE10 / IE11 compatibility modes #703

Closed
Havunen opened this issue Nov 4, 2015 · 4 comments
Closed

IE10 / IE11 compatibility modes #703

Havunen opened this issue Nov 4, 2015 · 4 comments
Labels
enhancement
Milestone
4.0

Comments

@Havunen
Copy link

Havunen commented Nov 4, 2015

Hi,

Is there any plans adding IE10 / IE11 compatibility modes (dropping support IE9)?
@jakubpawlowicz
Copy link
Collaborator

I plan to add more compatibility modes in the next version indeed. Is there anything particular you think about?

@corvae
Copy link

corvae commented May 20, 2016

One thing that doesn't work at the moment is '0px' being shortened to '0'. I haven't been able to pass zeroUnits:false as an option to grunt's cssmin, so will this be fixed by adding ie11 compatibility mode?

@jakubpawlowicz jakubpawlowicz modified the milestone: 4.0 Dec 12, 2016
jakubpawlowicz added a commit that referenced this issue Dec 27, 2016
@jakubpawlowicz
See #703 - moves default compatibility to IE10+.
6aa6c4c 
Why:

* It's high time to move it up as IE9 is relatively old now.
* Adds `ie9` compatibility mode to make it easy to go back
  to 3.x default.
@jakubpawlowicz
Copy link
Collaborator

@corvae sorry it's been a while, but could you let me know what do you mean by

is '0px' being shortened to '0'

?

Any examples of wrong behavior with that optimization?

jakubpawlowicz added a commit that referenced this issue Dec 30, 2016
@jakubpawlowicz
See #703 - changes default compatibility to IE10+.
b73ffab 
Why:

* It's high time to move it up as IE9 is relatively old now.
* Adds `ie9` compatibility mode to make it easy to go back
  to 3.x default.
jakubpawlowicz added a commit that referenced this issue Dec 30, 2016
@jakubpawlowicz
See #703 - adds ie10 alias to default compatibility.
cf36369
jakubpawlowicz added a commit that referenced this issue Dec 30, 2016
@jakubpawlowicz
See #703 - re-enables background longhand merging.
110c0cd 
Why:

* See #577 and #579 - these two clearly state the issue is about
  IE8 not IE9+, and according to tests and caniuse.com tables
  using `background-(clip|origin|size)` in `background` shorthand
  is supported on IE9+;
* At this point I have no idea why it was disabled at the time.
  One idea is that it was disabled because IE9 doesn't support
  `properties.spaceAfterClosingBrace` and these two issues
  overlappedi at the time of 3.2 branch. (both were "fixed" in 3.3);
* Let's enable it again, since the default mode is now IE10+.

** Important note **: Safari <7 and Android stock browser <4.4
does not support it either so you'll likely have to disable if
you still support those. Just use `--compatibility ie8` to do so.

Test case: https://jsfiddle.net/7zLwv7o0/5/
jakubpawlowicz added a commit that referenced this issue Dec 30, 2016
@jakubpawlowicz
See #703 - adds ie11 alias to default compatibility.
13ae37e
@jakubpawlowicz
Copy link
Collaborator

IE10/11 compatibility modes are in - let me know if you need anything specific there.
Also 4.0 will be IE10+ by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@jakubpawlowicz @Havunen @corvae