Merge in desmos functional changes from the past few years (screen reader support, thousands separators for numbers, many others) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oard-events Fix ff substitute keyboard events
add resetCursorOnBlur option.
Without this invalidation, a previous request to set selection can cause focus to move back to a mathquill after it has already been moved somewhere else.
…imeout-on-blur Blur invalidates request to update selection.
Useful in conjunction with overrideKeystroke.
…-keystroke Allow passing an event to keystroke.
This fixes a prayer bug where I wasn't resetting the cursor.parent back to the root
add cursor.resetToEnd() method
fix scroll with selection
base class is overriding ctrlseq for subclass "textit" and others
…ldern fix latex for textit command
Add mathspeak to inequality symbols
Known issue that the entirety of the text block is read aloud when pressing Delete.
Text command improvements
Add verbal support for reading and navigating nthroots
Writing -> converts to \to arrow
Interpret → as \to when it is pasted in
* Call updateMathspeak from the primary setAriaLabel() method if the active Mathquill element does not have focus (this was previously called in textarea, but wouldn't necessarily fire if an outsider was setting the label via the public API). * Add the colon symbol only when computing an aria-label + mathspeak for the active Mathquill-- should restore previously expected behavior.
Also updates tests.
…dering Consolidate ARIA label update code and use hidden span for static math
…update Short-circuit efficient latex update if old and new values are identical
jQuery 3.x has introduced a bunch of different focus bugs in the process of attempting to migrate to using native focus events in more cases, some of which remain unfixed in the latest version (3.6.0). Examples: * jquery/jquery#4859 * jquery/jquery#4856 * jquery/jquery#4950 * jquery/jquery#4867 Some unknown bug in this general class can make it so that Mathquill public api focus calls stop working because using jQuery to programatically trigger focus breaks. Work around this by switching to triggering native focus events instead of jQuery focus events.
Use native focus events insted of jQuery focus events
Fixes mathquill#950 by reverting mathquill#764 and mathquill#779 Unfortunately, this leaves us back in a place where superscript and subscript placement isn't very good when they're attached to tall blocks, but I think if we're going to fix that, we need to find a way to do it that's more robust to continuing to edit the expression.
Allow running CI with either CircleCI or Jenkins
Remove unreferenced air-demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.