Skip to content
This repository has been archived by the owner on Jul 15, 2021. It is now read-only.

More robust support for props change #25

Closed
jamesplease opened this issue Jul 10, 2019 · 0 comments
Closed

More robust support for props change #25

jamesplease opened this issue Jul 10, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@jamesplease
Copy link
Owner

jamesplease commented Jul 10, 2019

When a prop changes that cannot be changed, a warning should be logged.

More props should support being changed. Right now, only disabled can be changed.

The docs should list which props can be changed.

Props that cannot change:

  • nodeType
  • focusId
  • orientation
  • wrapping

But maybe it should just be limited to nodeType and focusId


useIsFocused should also warn if the focusId is changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant