Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing primitive: ml_z_extract_small #10

Closed
bclement-ocp opened this issue Oct 16, 2023 · 4 comments
Closed

Missing primitive: ml_z_extract_small #10

bclement-ocp opened this issue Oct 16, 2023 · 4 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@bclement-ocp
Copy link
Contributor

ml_z_extract_small was added as a fast path for ml_z_extract in ZArith 1.13 (see ocaml/Zarith#90 )

It can be aliased to ml_z_extract:

// Provides: ml_z_extract_small
// Requires: ml_z_extract
function ml_z_extract_small(z1, pos, len) {
  return ml_z_extract(z1, pos, len);
}
@hhugo
Copy link

hhugo commented Oct 26, 2023

@TyOverby, @pmwhite would you be able to look at this ?

@Enoumy
Copy link

Enoumy commented Oct 30, 2023

Thanks for reporting this and thanks for the suggested fix! The patch has been imported internally and should appear on the public release on our next push of our packages.

Thanks!

@hhugo
Copy link

hhugo commented Nov 6, 2023

@Enoumy, do you think you could do a minor release of zarith_stubs_js with this change ?

@dkalinichenko-js
Copy link
Contributor

@hhugo I'll do it shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

6 participants