Skip to content

Commit

Permalink
Revert "fix: using type text instead number for avoid region issue (#…
Browse files Browse the repository at this point in the history
…3538)"

This reverts commit 28c6ba1.
  • Loading branch information
louis-jan committed Sep 9, 2024
1 parent 6956ed1 commit 0c5ab22
Showing 1 changed file with 4 additions and 14 deletions.
18 changes: 4 additions & 14 deletions web/containers/SliderRightPanel/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ const SliderRightPanel = ({
onValueChanged,
}: Props) => {
const [showTooltip, setShowTooltip] = useState({ max: false, min: false })
const [val, setVal] = useState(value.toString())

useClickOutside(() => setShowTooltip({ max: false, min: false }), null, [])

return (
<div className="flex flex-col">
<div className="mb-3 flex items-center gap-x-2">
Expand All @@ -50,10 +48,7 @@ const SliderRightPanel = ({
<div className="relative w-full">
<Slider
value={[value]}
onValueChange={(e) => {
onValueChanged?.(e[0])
setVal(e[0].toString())
}}
onValueChange={(e) => onValueChanged?.(e[0])}
min={min}
max={max}
step={step}
Expand All @@ -68,29 +63,24 @@ const SliderRightPanel = ({
open={showTooltip.max || showTooltip.min}
trigger={
<Input
type="text"
type="number"
className="-mt-4 h-8 w-[60px]"
min={min}
max={max}
value={val}
value={String(value)}
disabled={disabled}
textAlign="right"
onBlur={(e) => {
if (Number(e.target.value) > Number(max)) {
onValueChanged?.(Number(max))
setVal(max.toString())
setShowTooltip({ max: true, min: false })
} else if (Number(e.target.value) < Number(min)) {
onValueChanged?.(Number(min))
setVal(min.toString())
setShowTooltip({ max: false, min: true })
}
}}
onChange={(e) => {
onValueChanged?.(e.target.value)
if (/^\d*\.?\d*$/.test(e.target.value)) {
setVal(e.target.value)
}
onValueChanged?.(Number(e.target.value))
}}
/>
}
Expand Down

0 comments on commit 0c5ab22

Please sign in to comment.