Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add engine in payload for nitro chat completion api #3482

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: add engine in payload for nitro chat completion api #3482

merged 1 commit into from
Aug 28, 2024

Conversation

marknguyen1302
Copy link
Contributor

Describe Your Changes

  • add engine in payload for nitro chat completion api
image

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Aug 28, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Aug 28, 2024

#3163

@marknguyen1302 marknguyen1302 changed the base branch from dev to main August 28, 2024 05:04
louis-jan
louis-jan approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add test later for the entire module

@Van-QA Van-QA merged commit 2fd0f20 into main Aug 28, 2024
9 checks passed
@Van-QA Van-QA deleted the fix/missing-engine-chat-completion-api branch August 28, 2024 05:56
@github-actions github-actions bot added this to the v.0.6.1 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@urmauur urmauur Awaiting requested review from urmauur

Assignees

@marknguyen1302 marknguyen1302

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v.0.6.0 (Jan x Cortex - Deprecated du...
Development

Successfully merging this pull request may close these issues.
3 participants
@marknguyen1302 @Van-QA @louis-jan