Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using type text instead number for avoid region issue #3538

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: using type text instead number for avoid region issue #3538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions web/containers/SliderRightPanel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ const SliderRightPanel = ({
onValueChanged,
}: Props) => {
const [showTooltip, setShowTooltip] = useState({ max: false, min: false })
const [val, setVal] = useState(value.toString())

useClickOutside(() => setShowTooltip({ max: false, min: false }), null, [])

return (
<div className="flex flex-col">
<div className="mb-3 flex items-center gap-x-2">
Expand All @@ -48,7 +50,10 @@ const SliderRightPanel = ({
<div className="relative w-full">
<Slider
value={[value]}
onValueChange={(e) => onValueChanged?.(e[0])}
onValueChange={(e) => {
onValueChanged?.(e[0])
setVal(e[0].toString())
}}
min={min}
max={max}
step={step}
Expand All @@ -63,24 +68,29 @@ const SliderRightPanel = ({
open={showTooltip.max || showTooltip.min}
trigger={
<Input
type="number"
type="text"
className="-mt-4 h-8 w-[60px]"
min={min}
max={max}
value={String(value)}
value={val}
disabled={disabled}
textAlign="right"
onBlur={(e) => {
if (Number(e.target.value) > Number(max)) {
onValueChanged?.(Number(max))
setVal(max.toString())
setShowTooltip({ max: true, min: false })
} else if (Number(e.target.value) < Number(min)) {
onValueChanged?.(Number(min))
setVal(min.toString())
setShowTooltip({ max: false, min: true })
}
}}
onChange={(e) => {
onValueChanged?.(Number(e.target.value))
onValueChanged?.(e.target.value)
if (/^\d*\.?\d*$/.test(e.target.value)) {
setVal(e.target.value)
}
}}
/>
}
Expand Down
Loading