Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setup jest for unit test hooks and component from joi #3540

Merged
merged 3 commits into from
Sep 5, 2024
Merged

chore: setup jest for unit test hooks and component from joi #3540

merged 3 commits into from
Sep 5, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Sep 3, 2024 •
edited
Loading

Describe Your Changes

  • WIP unit test component
Screenshot 2024-09-03 at 20 02 43 Screenshot 2024-09-03 at 20 03 03

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: chore Maintenance, operational label Sep 3, 2024
@urmauur urmauur self-assigned this Sep 3, 2024
@urmauur urmauur mentioned this pull request Sep 3, 2024
Closed
21 tasks
louis-jan
louis-jan reviewed Sep 4, 2024
View reviewed changes
joi/tsconfig.json Outdated Show resolved Hide resolved
louis-jan
louis-jan approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan
Copy link
Contributor

Please proceed, @urmauur. I will run the code coverage report, including the Joi project.

@urmauur urmauur marked this pull request as ready for review September 5, 2024 04:40
@urmauur urmauur merged commit 1ffb7f2 into dev Sep 5, 2024
7 checks passed
@urmauur urmauur deleted the chore/unit-test-ui-components branch September 5, 2024 04:41
@github-actions github-actions bot added this to the v.0.6.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

@marknguyen1302 marknguyen1302 Awaiting requested review from marknguyen1302

Assignees

@urmauur urmauur

Labels
type: chore Maintenance, operational
Projects
None yet
Milestone
v.0.6.0 (Jan x Cortex - Deprecated du...
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-jan