fix: prevent value empty string on slider right panel #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're doing this this sprint? @urmauur |
yes this is important, bc will broke the app cc @louis-jan |
Barecheck - Code coverage reportTotal: 57.31%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
|
Closes issue raised in #3602 (comment) |
dan-homebrew
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Context
since we allow 0.5 instead 0,5 to avoid issue regarding region number format, we change input on slider right panel using input string, we need prevent empty string when on change and on blur value.
Solution
we just need check length value when onBlur and onChange and apply to minimum value and update test case including test when value empty string
Fixes Issues
Screen.Recording.2024-09-11.at.09.56.52.mov
Self Checklist