Add support for 'o1-preview' and 'o1-mini' models #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @louis-jan 🙏 |
dan-homebrew
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
@louis-jan This lgtm, but can you check through to make sure it doesn't brick for existing users?
Add support for 'o1-preview' and 'o1-mini' model names in the OpenAI API. * **Update `models.json`**: - Add 'o1-preview' model details with appropriate parameters and metadata. - Add 'o1-mini' model details with appropriate parameters and metadata. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/janhq/jan?shareId=XXXX-XXXX-XXXX-XXXX).
RONNCC
force-pushed
the
add-o1-models
branch
from
789a22d
to
c4ddfd0
Compare
|
Sounds good and appreciate y'alls assistance to review! I'll assume y'all will own the rest of the process (i.e. merging) -- Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for 'o1-preview' and 'o1-mini' model names in the OpenAI API.
models.json:Closes #3652
For more details, open the Copilot Workspace session.