Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct prompt template for Phi3 Medium model #3665

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Sep 16, 2024

Description

  • There was an issue with the Phi-3 Medium prompt template (0.5.3), which lead to a wrong output like this:
Sept 16 Screenshot from Discord
  • This is the second attempt at correcting the model prompt template, and the result should be like this:
Sept 16 Screenshot from Discord (1)

Changes made

  1. The model version has been updated from "1.3" to "1.4".

  2. The prompt template has been modified:

    • Old: "<|user|> {prompt}<|end|><|assistant|><|end|>"
    • New: "<|user|> {prompt}<|end|><|assistant|>"

    The main difference is the removal of "<|end|>" after "<|assistant|>".

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Sep 16, 2024
Copy link
Contributor

github-actions bot commented Sep 16, 2024

Barecheck - Code coverage report

Total: 57.31%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@louis-jan louis-jan merged commit daf372f into main Sep 16, 2024
9 checks passed
@louis-jan louis-jan deleted the fix/phi3-medium-prompt-template branch September 16, 2024 08:44
@github-actions github-actions bot added this to the v0.5.5 milestone Sep 16, 2024
@louis-jan louis-jan modified the milestones: v0.5.5, v0.5.4 Sep 16, 2024
@louis-jan louis-jan restored the fix/phi3-medium-prompt-template branch September 16, 2024 10:08
@louis-jan louis-jan mentioned this pull request Sep 16, 2024
3 tasks
@louis-jan louis-jan deleted the fix/phi3-medium-prompt-template branch September 17, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants