Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the condition for generating the title #3702

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Sep 19, 2024

Describe Your Changes

Preventing title generation. This ensures that the title generation logic runs only for local models

Changes code

Added new condition on generateThreadTitle

Screen.Recording.2024-09-19.at.14.48.08.mov

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Sep 19, 2024
@urmauur urmauur added this to the v0.5.5 milestone Sep 19, 2024
@urmauur urmauur self-assigned this Sep 19, 2024
@urmauur urmauur marked this pull request as ready for review September 19, 2024 08:16
Copy link
Contributor

Barecheck - Code coverage report

Total: 57.72%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@urmauur urmauur merged commit 194093d into dev Sep 20, 2024
11 checks passed
@urmauur urmauur deleted the fix/generate-thread-titles branch September 20, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: avoid 2nd remote API request to generate thread titles
2 participants