fix: #3515 - The default assistant instructions are ignored

[louis-jan]

Describe Your Changes

Fixed the issue #3515

Default instructions are no longer read from the configuration file when launching a new thread on linux.
I tried to remove the ~/jan file, remove my .AppImage file and install it from deb source (with today latest version) then fill again the "instructions" field in ~/jan/assistant/jan/assistant.json . Nothing work. I have to copy / paste my instructions from one thread to another instead of just spawning a new thread and go with my "all purpose for my needs" dev instructions.

Fixes Issues

• Closes bug: Default instruction from ~/jan/assistants/jan/assistant.json no longer work on linux #3515

Changes made

New Tests in useCreateNewThread.test.ts

1. Creating a New Thread:

   • Test Case: it('should create a new thread')
   • Description: This test mocks the dependencies and verifies that the requestCreateNewThread function properly sets up and saves a new thread. Expectations include checking that specific atoms were set and that the extensionManager.get method was called.

2. Creating a New Thread with Instructions:

   • Test Case: it('should create a new thread with instructions')
   • Description: This test mocks the dependencies and adds an instruction to the new assistant. The test expects the new assistant to have the correct instruction and that the necessary atoms were set.

3. Creating a New Thread with Previous Instructions:

   • Test Case: it('should create a new thread with previous instructions')
   • Description: Similar to the previous test, this test uses previous instructions from another assistant. The test ensures that the correct instructions are copied and the atoms were set.

4. Creating an Empty Thread (With Warning Toast):

   • Test Case: it('should show a warning toast if trying to create an empty thread')
   • Description: This test simulates a situation where creating a thread is not possible due to missing required data. The expectation is that a warning toast is shown.

5. Updating Thread Metadata:

   • Test Case: it('should update thread metadata')
   • Description: This test mocks the dependencies and checks if the metadata of an existing thread can be updated successfully.

Code Change

1. Modification in useCreateNewThread.ts:
   • The variable instructions is now initialized with assistant.instructions instead of undefined.
   • Before:

     let instructions: string | undefined = undefined

   • After:

     let instructions: string | undefined = assistant.instructions

This change reflects the behavior where the instructions of the assistant are directly used if they are available.

[github-actions]

Barecheck - Code coverage report

Total: 62.56%

Your code coverage diff: 0.54% ▴

Uncovered files and lines

File	Lines
web/hooks/useCreateNewThread.ts	42, 44, 49-50, 53-54