Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added more test inside containers component #3765

Merged
merged 3 commits into from
Oct 16, 2024
Merged

test: added more test inside containers component #3765

merged 3 commits into from
Oct 16, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Oct 3, 2024 •
edited
Loading

Describe Your Changes

Increased test coverage

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur requested a review from louis-jan October 3, 2024 13:48
@urmauur urmauur self-assigned this Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

Barecheck - Code coverage report

Total: 70%

Your code coverage diff: 1.05% ▴

✅ All code changes are covered

@urmauur urmauur added the category: tests Automated testing label Oct 15, 2024
@urmauur urmauur marked this pull request as ready for review October 16, 2024 02:23
@urmauur urmauur changed the title [WIP]test: added more test inside containers component test: added more test inside containers component Oct 16, 2024
louis-jan
louis-jan approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 19a60bc into dev Oct 16, 2024
9 checks passed
@urmauur urmauur deleted the test/containers branch October 16, 2024 02:45
@github-actions github-actions bot added this to the v0.5.7 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@dan-homebrew dan-homebrew Awaiting requested review from dan-homebrew

Assignees

@urmauur urmauur

Labels
category: tests Automated testing
Projects
None yet
Milestone
v0.5.7
Development

Successfully merging this pull request may close these issues.

test: adding more tests to containers component
2 participants
@urmauur @louis-jan