Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update convo summary #378

Merged
merged 3 commits into from
Oct 18, 2023
Merged

chore: update convo summary #378

merged 3 commits into from
Oct 18, 2023

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Oct 17, 2023

The conversation summary has been removed due to plugin-scoped inference refactoring. This reworked PR function operates on a new extension point & to avoid duplicated SSE fetch codes.

Screenshot 2023-10-17 at 21 33 44

@louis-jan louis-jan marked this pull request as ready for review October 17, 2023 14:43
@louis-jan
Copy link
Contributor Author

louis-jan commented Oct 17, 2023

User start with a very first prompt -> default summary is "Prompt: [User Prompt]", attempt to summary the conversation, if the summary is too long, attempt in the next time until model get a good context.

cc @namchuai

@0xSage
Copy link
Contributor

0xSage commented Oct 18, 2023

User start with a very first prompt -> default summary is "User request: prompt" (similar to Chat GPT), attempt to summary the conversation, if the summary is too long, attempt in the next time until model get a good context.

Can we redact the "user request"? It can get a bit repetitive. Lets just do "prompt"

@louis-jan
Copy link
Contributor Author

Yeah sure

Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @louis-jan . LGTM

@louis-jan louis-jan merged commit c623a9b into main Oct 18, 2023
3 checks passed
@louis-jan louis-jan deleted the chore/conversation-summary branch October 18, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants