-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out an appropriate way to test this #3
Labels
Comments
Good ideas! Smoke tests would be nice indeed. But yeah some things are just way too experimental maybe? For example, I would imagine that a good calibration routine could eliminate all manual steps, in which case it would be a bit pointless to test those things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In a project this complicated (i.e. one which relies on hardware, real-world lighting, browser features hidden behind flags, etc.) I imagine it's difficult to write useful unit tests in any conventional way. However, I also think it's really important that developers have a couple smoke tests to validate that they aren't breaking things when they check in code. I can think of a few steps that would help make the code more testable:
navigator.mediaDevices.getUserMedia()
out ofCameraVideo
and instead pass a stream as a prop.Given that Paper Programs is still young, there might be other higher priorities right now. I just wanted to throw this out there as something to think about while moving forward or designing new parts of the system.
The text was updated successfully, but these errors were encountered: