Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update only if i'm the touched item #1104

Closed
wants to merge 2 commits into from

Conversation

DavidBabel
Copy link

see #1103

src/FastField.tsx Outdated Show resolved Hide resolved
@tlenclos
Copy link

We have a big form in our app and this PR is improving performance 👍
The user experience is still very bad for our user but this is a move in the right direction.

@DavidBabel
Copy link
Author

@tlenclos be carefull, this "quick win fix" may loss some features of Formik, i'm not enough comfortable with the library to know yet.

the real performance improvement will come from #1103, but it's a deeper change.

@jaredpalmer
Copy link
Owner

jaredpalmer commented Nov 13, 2018

While this would work for Formik v1's registration, i think it has some problems with how I plan to do field registration in v2. In v1 we naively assume there is 1:1 relationship with fields to components. This is why we didn't implement ErrorMessage with field (because that would break). However, in v2, this won't be the case. This trick could still work though, the value would just include some kind of random number or uuid.

@jaredpalmer
Copy link
Owner

However, we may not even really need registration (or rather it may become hard to understand) with fiber/suspense and with upcoming useField. Not sure yet.

@stale stale bot added the stale label Jan 12, 2019
@jaredpalmer
Copy link
Owner

Closing in favor of #2749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants